Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Date-mocks in unit tests #4

Merged
merged 2 commits into from
Aug 31, 2022
Merged

fix Date-mocks in unit tests #4

merged 2 commits into from
Aug 31, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 23, 2022 •
edited

Checklist

mcollina
mcollina approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TommyDew42
Copy link
Contributor

How's this going to improve the tests?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 23, 2022 •
edited

What seems wrong here in master-branch? ;)

one-line-logger/test/helpers.js

Line 53 in 5bc4220

Date.prototype.getHours = Date.prototype.getHours

TommyDew42
TommyDew42 reviewed Aug 23, 2022
View reviewed changes
test/helpers.js Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 31, 2022

@mcollina

I can not merge this PR, as it is not part of fastify/libraries or fastify/plugins team.

@mcollina mcollina merged commit 2c20d55 into fastify:master Aug 31, 2022
@Uzlopak Uzlopak deleted the fix-Date-Mocks branch August 31, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyDew42 TommyDew42 TommyDew42 left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uzlopak @TommyDew42 @mcollina