Skip to content

Commit

Permalink
perf: use node: prefix to bypass require.cache call for builtins (#384
Browse files Browse the repository at this point in the history
)

* perf: use `node:` prefix to bypass require.cache call for builtins

See fastify/fastify-static#407

* docs: use `node:` prefix to bypass require.cache call for builtins
  • Loading branch information
Fdawgs committed Sep 10, 2023
1 parent 033df43 commit db34d0e
Show file tree
Hide file tree
Showing 16 changed files with 39 additions and 39 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ To use include files please extend your template options as follows:
```js
// get a reference to resolve
const resolve = require("path").resolve;
const resolve = require('node:path').resolve;
// other code ...
// in template engine options configure how to resolve templates folder
options: {
Expand Down Expand Up @@ -344,7 +344,7 @@ To configure liquid you need to pass the engine instance as engine option:

```js
const { Liquid } = require("liquidjs");
const path = require("path");
const path = require('node:path');

const engine = new Liquid({
root: path.join(__dirname, "templates"),
Expand All @@ -370,7 +370,7 @@ This behaviour is recommended by the doT team [here](https://github.com/olado/do
To make it possible it is necessary to provide a `root` or `templates` option with the path to the template directory.

```js
const path = require("path");
const path = require('node:path');

fastify.register(require("@fastify/view"), {
engine: {
Expand Down
2 changes: 1 addition & 1 deletion examples/example-async.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const { promisify } = require('util')
const { promisify } = require('node:util')
const sleep = promisify(setTimeout)
const templates = 'templates'

Expand Down
2 changes: 1 addition & 1 deletion examples/example-ejs-with-some-options.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const fastify = require('fastify')()
const resolve = require('path').resolve
const resolve = require('node:path').resolve
const templatesFolder = 'templates'
const data = { text: 'Hello from EJS Templates' }

Expand Down
16 changes: 8 additions & 8 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
'use strict'

const fp = require('fastify-plugin')
const readFile = require('fs').readFile
const accessSync = require('fs').accessSync
const existsSync = require('fs').existsSync
const mkdirSync = require('fs').mkdirSync
const readdirSync = require('fs').readdirSync
const resolve = require('path').resolve
const join = require('path').join
const { basename, dirname, extname } = require('path')
const readFile = require('node:fs').readFile
const accessSync = require('node:fs').accessSync
const existsSync = require('node:fs').existsSync
const mkdirSync = require('node:fs').mkdirSync
const readdirSync = require('node:fs').readdirSync
const resolve = require('node:path').resolve
const join = require('node:path').join
const { basename, dirname, extname } = require('node:path')
const HLRU = require('hashlru')
const supportedEngines = ['ejs', 'nunjucks', 'pug', 'handlebars', 'mustache', 'art-template', 'twig', 'liquid', 'dot', 'eta']

Expand Down
2 changes: 1 addition & 1 deletion test/helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const POV = require('..')
const Fastify = require('fastify')
const minifier = require('html-minifier')
const fs = require('fs')
const fs = require('node:fs')
const dot = require('dot')
const handlebars = require('handlebars')
const { Liquid } = require('liquidjs')
Expand Down
2 changes: 1 addition & 1 deletion test/test-art-template.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const path = require('path')
const path = require('node:path')

test('reply.view with art-template engine and custom templates folder', t => {
t.plan(6)
Expand Down
4 changes: 2 additions & 2 deletions test/test-dot.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const { existsSync, rmdirSync } = require('fs')
const { join } = require('path')
const { existsSync, rmdirSync } = require('node:fs')
const { join } = require('node:path')
const pino = require('pino')
const split = require('split2')
const compileOptions = {
Expand Down
2 changes: 1 addition & 1 deletion test/test-ejs-async.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const fs = require('fs')
const fs = require('node:fs')

test('reply.view with ejs engine and async: true (global option)', t => {
t.plan(6)
Expand Down
2 changes: 1 addition & 1 deletion test/test-ejs-with-snapshot.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const path = require('path')
const path = require('node:path')
const ejs = require('ejs')
const templatesFolder = 'templates'
const options = {
Expand Down
16 changes: 8 additions & 8 deletions test/test-ejs.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const fs = require('fs')
const path = require('path')
const fs = require('node:fs')
const path = require('node:path')
const minifier = require('html-minifier')
const minifierOpts = {
removeComments: true,
Expand Down Expand Up @@ -789,7 +789,7 @@ test('reply.view with ejs engine, template folder specified, include files (ejs
t.plan(7)
const fastify = Fastify()
const ejs = require('ejs')
const resolve = require('path').resolve
const resolve = require('node:path').resolve
const templatesFolder = 'templates'
const options = {
filename: resolve(templatesFolder), // needed for include files to be resolved in include directive ...
Expand Down Expand Up @@ -839,7 +839,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
t.plan(7)
const fastify = Fastify()
const ejs = require('ejs')
const resolve = require('path').resolve
const resolve = require('node:path').resolve
const templatesFolder = 'templates'
const options = {
filename: resolve(templatesFolder),
Expand Down Expand Up @@ -888,7 +888,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
t.plan(7)
const fastify = Fastify()
const ejs = require('ejs')
const resolve = require('path').resolve
const resolve = require('node:path').resolve
const templatesFolder = 'templates'
const options = {
filename: resolve(templatesFolder),
Expand Down Expand Up @@ -936,7 +936,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
t.plan(7)
const fastify = Fastify()
const ejs = require('ejs')
const resolve = require('path').resolve
const resolve = require('node:path').resolve
const templatesFolder = 'templates'
const options = {
filename: resolve(templatesFolder),
Expand Down Expand Up @@ -986,7 +986,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
t.plan(7)
const fastify = Fastify()
const ejs = require('ejs')
const resolve = require('path').resolve
const resolve = require('node:path').resolve
const templatesFolder = 'templates'
const options = {
filename: resolve(templatesFolder),
Expand Down Expand Up @@ -1035,7 +1035,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
t.plan(7)
const fastify = Fastify()
const ejs = require('ejs')
const resolve = require('path').resolve
const resolve = require('node:path').resolve
const templatesFolder = 'templates'
const options = {
filename: resolve(templatesFolder),
Expand Down
4 changes: 2 additions & 2 deletions test/test-eta.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const fs = require('fs')
const path = require('path')
const fs = require('node:fs')
const path = require('node:path')

const pointOfView = require('../index')
const { Eta } = require('eta')
Expand Down
8 changes: 4 additions & 4 deletions test/test-handlebars.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const fs = require('fs')
const { join } = require('path')
const fs = require('node:fs')
const { join } = require('node:path')
const proxyquire = require('proxyquire')

require('./helper').handleBarsHtmlMinifierTests(t, true)
Expand Down Expand Up @@ -513,7 +513,7 @@ test('reply.view with ejs engine, template folder specified, include files (ejs
t.plan(7)
const fastify = Fastify()
const ejs = require('ejs')
const resolve = require('path').resolve
const resolve = require('node:path').resolve
const templatesFolder = 'templates'
const options = {
filename: resolve(templatesFolder), // needed for include files to be resolved in include directive ...
Expand Down Expand Up @@ -563,7 +563,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
t.plan(7)
const fastify = Fastify()
const ejs = require('ejs')
const resolve = require('path').resolve
const resolve = require('node:path').resolve
const templatesFolder = 'templates'
const options = {
filename: resolve(templatesFolder),
Expand Down
2 changes: 1 addition & 1 deletion test/test-mustache.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const fs = require('fs')
const fs = require('node:fs')
const minifier = require('html-minifier')
const proxyquire = require('proxyquire')
const minifierOpts = {
Expand Down
2 changes: 1 addition & 1 deletion test/test-nunjucks.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const path = require('path')
const path = require('node:path')

require('./helper').nunjucksHtmlMinifierTests(t, true)
require('./helper').nunjucksHtmlMinifierTests(t, false)
Expand Down
2 changes: 1 addition & 1 deletion test/test-pug.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const Fastify = require('fastify')
const fs = require('fs')
const fs = require('node:fs')
const proxyquire = require('proxyquire')

require('./helper').pugHtmlMinifierTests(t, true)
Expand Down
6 changes: 3 additions & 3 deletions test/test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict'

const os = require('os')
const os = require('node:os')
const t = require('tap')
const test = t.test
const sget = require('simple-get').concat
const path = require('path')
const fs = require('fs')
const path = require('node:path')
const fs = require('node:fs')
const Fastify = require('fastify')

test('fastify.view exist', t => {
Expand Down

0 comments on commit db34d0e

Please sign in to comment.