Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to access res.locals variable across all views #209

Merged
merged 2 commits into from Feb 5, 2021

Conversation

yaneony
Copy link
Contributor

@yaneony yaneony commented Feb 4, 2021

See #207.
Is test still necessary for one-liner?

Checklist

@Eomm
Copy link
Member

Eomm commented Feb 4, 2021

Is test still necessary for one-liner?

Yes, you could just transform the code in the issue to a test that should fail before your changes, and pass after it.

This will assure your fix will be preserved overtime

@yaneony yaneony changed the title Added possibility to access res.locals variable across all views. Possibility to access res.locals variable across all views. Feb 5, 2021
@yaneony yaneony changed the title Possibility to access res.locals variable across all views. Possibility to access res.locals variable across all views Feb 5, 2021
@yaneony
Copy link
Contributor Author

yaneony commented Feb 5, 2021

Test added and passed.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4d0146a into fastify:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants