Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for marko #289

Merged
merged 1 commit into from Dec 22, 2021
Merged

drop support for marko #289

merged 1 commit into from Dec 22, 2021

Conversation

ovhemert
Copy link
Contributor

Removes the support for marko, since newer versions are not compatible anymore and a good replacement is available: @marko/fastify.

See #218

Checklist

Eomm
Eomm approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as major release

@Eomm Eomm requested a review from a team December 22, 2021 10:11
zekth
zekth approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as major

@mcollina mcollina merged commit ff5604e into fastify:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekth zekth zekth approved these changes

@Eomm Eomm Eomm approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ovhemert @zekth @Eomm @Fdawgs @mcollina