Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Handlebars compile options and data variables #383

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Add support for Handlebars compile options and data variables #383

merged 1 commit into from
Sep 12, 2023

Conversation

mohd-akram
Copy link
Contributor

Checklist

@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 11, 2023

Can we have some typings?

@mohd-akram
Copy link
Contributor Author

@Uzlopak Where?

gurgunday
gurgunday approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation lgtm

useDataVariables sounds a little vague but the README clearly explains what it does

mcollina
mcollina approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 39f16ec into fastify:master Sep 12, 2023
15 checks passed
@mohd-akram mohd-akram deleted the handlebars-opts branch September 12, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mohd-akram @Uzlopak @mcollina @Eomm @gurgunday