Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: swap toad cache for hashlru #418

Merged
merged 1 commit into from
Mar 1, 2024
Merged

chore: swap toad cache for hashlru #418

merged 1 commit into from
Mar 1, 2024

Conversation

mweberxyz
Copy link
Contributor

@mweberxyz mweberxyz commented Feb 28, 2024 •
edited

Swap in toad-cache for hashlru as requested here: #414 (comment)

Benchmarks

Benchmark Node 18 PR Node 18 Base Node 20 PR Node 20 Base Node 21 PR Node 21 Base
express.js 8943 8871 9423 8799 9183 9151
fastify.js 35263 42847 45151 44095 43007 42079
fastify-art.js 10167 9711 11671 12007 9431 9023
fastify-dot.js 49887 48895 48639 48671 47039 47487
fastify-eta.js 27999 28111 29983 30767 37151 35647
fastify-pug.js 42079 46751 49055 48127 35647 46271
fastify-twig.js 32015 36639 40063 40095 33631 37759
fastify-liquid.js 6975 6975 7363 8335 7611 7583
fastify-mustache.js 33535 32799 34943 34751 33855 34303
fastify-nunjucks.js 42751 42911 45759 43935 41663 42399
fastify-ejs-async.js 35967 36223 43007 46431 41855 44191
fastify-ejs-minify.js 12303 12991 15407 14983 14391 14263
fastify-handlebars.js 26863 27135 32799 31839 26543 29423
fastify-ejs-local-layout.js 28559 32031 34079 32591 32191 33151
fastify-ejs-global-layout.js 34303 41119 41887 40927 40543 40799

Checklist

@mweberxyz mweberxyz marked this pull request as draft February 28, 2024 23:57
gurgunday
gurgunday reviewed Feb 29, 2024
View reviewed changes
index.js Outdated Show resolved Hide resolved
gurgunday
gurgunday reviewed Feb 29, 2024
View reviewed changes
index.js Outdated Show resolved Hide resolved
@mweberxyz mweberxyz force-pushed the chore/swap-toad-cache-for-hashlru branch 3 times, most recently from 2e34ed7 to 622c303 Compare March 1, 2024 02:22
gurgunday
gurgunday reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after a rebase

@mweberxyz mweberxyz force-pushed the chore/swap-toad-cache-for-hashlru branch from 622c303 to d9d9184 Compare March 1, 2024 16:02
@mweberxyz mweberxyz requested a review from gurgunday March 1, 2024 16:03
@mweberxyz mweberxyz marked this pull request as ready for review March 1, 2024 16:04
@gurgunday gurgunday merged commit 988042f into fastify:master Mar 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweberxyz @gurgunday