Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no data to be passed #53

Merged
merged 2 commits into from
Apr 6, 2018
Merged

Allow no data to be passed #53

merged 2 commits into from
Apr 6, 2018

Conversation

robinvdvleuten
Copy link
Contributor

This makes passing data optional as mentioned by #52.

@robinvdvleuten robinvdvleuten mentioned this pull request Apr 6, 2018
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test and a template to verify this use case?

@robinvdvleuten
Copy link
Contributor Author

@delvedor I've added a testcase and a corresponding template.

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit 0d13e7b into fastify:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants