Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error from/to commit delta #25

Closed
Eomm opened this issue Jun 5, 2019 · 0 comments
Closed

error from/to commit delta #25

Eomm opened this issue Jun 5, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@Eomm
Copy link
Member

Eomm commented Jun 5, 2019

This works:
releasify draft --from-commit 96a621462e612da048837c923bb4b570c1e0b8be --to-commit HEAD

this not:
releasify draft --from-commit 96a621462e612da048837c923bb4b570c1e0b8be

when the repository doesn't have any tag already created.

We just need to add a || HEAD

releasify/lib/commands/draft.js

Line 46 in 4aa58e0

toCommit = await git.getLastTagCommit(tagPattern)

  • test
@Eomm Eomm added bug Something isn't working good first issue Good for newcomers labels Jun 5, 2019
apsknight added a commit to apsknight/releasify that referenced this issue Oct 5, 2019
@apsknight
Fix fastify#25: Set toCommit to HEAD when not specified as arg and re…
dacf11a 
…po does not has any tag already created
@apsknight apsknight mentioned this issue Oct 5, 2019
Closed
piemme added a commit to piemme/releasify that referenced this issue Oct 7, 2020
@piemme
Fix fastify#25: Set toCommit to HEAD when not specified as arg, and a…
443d6ac 
…dding a unit test
@piemme piemme mentioned this issue Oct 7, 2020
Merged
3 tasks
@Eomm Eomm closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #25: Set toCommit to HEAD when not specified as arg apsknight/releasify
1 participant
@Eomm