Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use request.protocol to check for HTTPS #238

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: use request.protocol to check for HTTPS #238

merged 1 commit into from
Mar 22, 2024

Conversation

mohd-akram
Copy link
Contributor

The header shouldn't be read unless trustProxy is true.

Checklist

gurgunday
gurgunday approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit 75b226c into fastify:master Mar 22, 2024
19 checks passed
@mohd-akram mohd-akram deleted the fix-protocol-check branch March 22, 2024 17:02
@gurgunday gurgunday mentioned this pull request Apr 15, 2024
Closed
2 tasks
@rktyt rktyt mentioned this pull request May 13, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohd-akram @gurgunday