Skip to content
This repository has been archived by the owner on Jul 8, 2023. It is now read-only.

Fix broken links #313

Merged
merged 10 commits into from
Dec 15, 2021
Merged

Fix broken links #313

merged 10 commits into from
Dec 15, 2021

Conversation

luisorbaiceta
Copy link
Member

@luisorbaiceta luisorbaiceta commented Dec 15, 2021 •
edited

Due to some reports about broken links, I'm opening this PR to detect all the edge cases that were not covered by the previous website and fix current reports.

Broken Links list:

  • website

  • website

  • Missing encapsulation svg

  • website

  • docs: needs to be fixed in fastify/fastify

  • web: needs to be fixed in fastify/website

Checklist

@luisorbaiceta luisorbaiceta mentioned this pull request Dec 15, 2021
Closed
2 tasks
@luisorbaiceta
Copy link
Member Author

@jsumners seems that previous links like /docs/foo/bar were 404s in the previous website too due to wrong version remapping. I'll do my best to find any possible missing edge case or link type but would really appreciate a hand on this. There are SOO many link types

@jsumners
Copy link
Member

There are SOO many link types

I refer you back to my original comment -- fastify/fastify#3474 (comment)

I'm really not happy with the current way our site is generated. It was a really valiant effort to keep as many versions as possible on the site, but it doesn't scale and is very unmaintainable.

@luisorbaiceta
Copy link
Member Author

luisorbaiceta commented Dec 15, 2021 •
edited

Agree, however my concern will be to try to fix this as I really don't know the status of new site.

@luisorbaiceta
Copy link
Member Author

@jsumners please check the list above, I will document all the broken links

@luisorbaiceta luisorbaiceta force-pushed the fix/broken-links branch 2 times, most recently from 780ac63 to 5d1690e Compare December 15, 2021 17:42
@luisorbaiceta
Copy link
Member Author

Website links have been fix. I will migrate the fastify/fastify part to that repo and open a separate PR so we can keep track from there. Let's wait to merge this till I have fixed that so I can check that ALL the links are correct in dev.

@luisorbaiceta luisorbaiceta marked this pull request as ready for review December 15, 2021 21:34
@luisorbaiceta
Copy link
Member Author

Every single link checked

mcollina
mcollina approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k lgtm

@jsumners
Copy link
Member

Every single link checked

tenor

@jsumners jsumners merged commit 02a11ff into master Dec 15, 2021
@jsumners jsumners deleted the fix/broken-links branch December 15, 2021 22:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luisorbaiceta @jsumners @mcollina