Make node versions dynamic #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdawgs
requested changes
Apr 22, 2024
|
Should package managers be tested cross platform? |
Probably leave those on Ubuntu only as well, so they match what the main Fastify repo is doing. :) If you could update the readme with the new option as well then this PR'll be good to go! |
|
Done, let me know if the README could be improved |
Fdawgs
previously approved these changes
Apr 22, 2024
|
Just reverted an unnecessary change to benchmark |
Fdawgs
approved these changes
Apr 22, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us use the centralized workflow for most libraries
Examples of where it will be used if merged:
fastify/proxy-addr#61 (review)
fastify/fluent-json-schema#242
fastify/process-warning#104
and other
@fastify/librariesrepos