add action-vallidator #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase with the fixed workflow? |
|
done, let's merge it? |
Eomm
reviewed
Jun 9, 2023
|
|
||
| - name: Lint Workflows | ||
| run: | | ||
| find .github/workflows -type f \( -iname \*.yaml -o -iname \*.yml \) \ |
There was a problem hiding this comment.
is it relative to the this repo or the one that uses this action?
There was a problem hiding this comment.
Should be Repo as the action failed when there was invalid workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validates the workflows files here so it won't break fastify repos that use it
please add it as required check before merging
ref:
mostly took from: https://github.com/mpalmer/action-validator/blob/65a2ff41bd4bfad8ae36dd005fb4e7711d3fdad7/.github/workflows/qa.yml#LL178C1-L196C56