Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload different apps in the same bucket #2

Closed
mrtj opened this issue Jan 23, 2017 · 8 comments
Closed

Upload different apps in the same bucket #2

mrtj opened this issue Jan 23, 2017 · 8 comments

Comments

@mrtj
Copy link

mrtj commented Jan 23, 2017

Hi, why "it is highly suggested that you make a separate bucket for each of the apps"? In our company we are maintaining dozens of app releases in a white-label manner so it is rather inconvenient to have a separate bucket just for the release of each of theses apps. Also, AWS accounts have a limit of 100 buckets by default and each app consumes a bucket from this pool shared with other buckets not used for releasing the apps. Instead the number of objects in a bucket is unlimited.

I tried to organize one bucket for all apps configuring the path parameter to include the bundle id:

aws_s3(
    ipa: "artifacts/build/MyApp.ipa",
    path: "{CFBundleIdentifier}/v{CFBundleShortVersionString}_b{CFBundleVersion}/"
)

but I noticed that /index.html and /version.json is overwritten in the root folder of the bucket with the references to the last app uploaded. Is it possible to move these files in the folder specified by path?

@fhickman
Copy link
Contributor

Agreed, it would be very handy to have an app_path configuration variable (which would default to the bucket root), and could be used to organize apps (or branches of apps) under a single S3 bucket.

@joshdholtz
Copy link
Member

@mrtj I think I had it "highly suggested" because I didn't test it with multiple apps in the same bucket 😬 I can work on adding this feature though - it makes sense and I really don't know why I had it as that in the first place

@joshdholtz
Copy link
Member

@mrtj @fhickman I just created #11 to add this feature. If either of you would like to review/try the PR before I merge that would be greatly appreciated 😊

@mrtj
Copy link
Author

mrtj commented Feb 1, 2017

Wonderful! I would love to try your PR but being very newbie in ruby/ruby package manager I don't know how could I install a temporary version of aws_s3 plugin from your branch?

@joshdholtz
Copy link
Member

@mrtj Try changing your Pluginfile to following and then run bundle install...

gem 'fastlane-plugin-s3', git: 'https://github.com/joshdholtz/fastlane-plugin-s3.git', branch: 'app-directory'

@fhickman
Copy link
Contributor

@joshdholtz I've tried it out locally, works like a charm. You've got my vote for merging it into master.

Thanks!

@n1mda
Copy link

n1mda commented Feb 15, 2017

Can you release version 0.2.2 so this is available without pointing the gemfile to a specific branch?

@joshdholtz
Copy link
Member

@n1mda Should be released now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants