Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple app directories in same bucket #11

Merged
merged 2 commits into from
Feb 14, 2017
Merged

Multiple app directories in same bucket #11

merged 2 commits into from
Feb 14, 2017

Conversation

joshdholtz
Copy link
Member

Closes #2

lane :apk1_multi do
  aws_s3(
    bucket: 'fastlane-plugin-s3',
    region: 'us-east-2',
    app_directory: 'android',
    apk: './fastlane/apk1/BanditTheCat.apk',
  )
end

@rpassis
Copy link

rpassis commented Feb 2, 2017

Hey Josh thanks for these changes.

I've been able to test them and can confirm they work as expected

For the following config

AWS_S3_BUCKET=my_bucket
AWS_S3_PATH=a/b/c
def upload_to_s3
  aws_s3(
      bucket: ENV['AWS_S3_BUCKET'],
      region: ENV["AWS_S3_REGION"],
      access_key: ENV["AWS_ACCESS_KEY"],
      secret_access_key: ENV["AWS_SECRET_ACCESS_KEY"],
      app_directory: ENV['AWS_S3_PATH'],
      upload_metadata: true,
  )
end

The result is the following directory structure:

my_bucket/a/b/c/index.html
my_bucket/a/b/c/version.html
my_bucket/a/b/c/v{CFBundleShortVersionString}_b{CFBundleVersion}/MyApp.ipa
my_bucket/a/b/c/v{CFBundleShortVersionString}_b{CFBundleVersion}/MyApp.ipa.dSYM.zip
my_bucket/a/b/c/v{CFBundleShortVersionString}_b{CFBundleVersion}/MyApp.plist

@joshdholtz joshdholtz merged commit f976fe3 into master Feb 14, 2017
@joshdholtz joshdholtz deleted the app-directory branch February 14, 2017 20:46
jaximan pushed a commit to jaximan/fastlane-plugin-s3 that referenced this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants