Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept multiple xccov_file_direct_path #196

Merged
merged 6 commits into from Mar 5, 2022
Merged

Accept multiple xccov_file_direct_path #196

merged 6 commits into from Mar 5, 2022

Conversation

manicmaniac
Copy link
Contributor

Close #195

  • Define xccov_file_direct_path option to receive both a string and an array of strings.
    • To not break backward compatibility, I didn't change the option key (ideally it should be plural though).
  • Set up rspec and CI using GitHub Actions.
  • Add minimal specs to check if xccov_file_direct_path option works.

@manicmaniac
Copy link
Contributor Author

@joshdholtz I would appreciate if you could take a look at this one.

@joshdholtz
Copy link
Member

Adding to my list!

@joshdholtz joshdholtz self-assigned this Feb 2, 2022
@ryanbourneuk
Copy link

As a note - I've been using this locally for a project and it's worked perfectly. Thanks @manicmaniac!

joshdholtz
joshdholtz approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good! Thank you for adding support for multiple files AND starting the tests 😍

@joshdholtz joshdholtz merged commit 3af272f into fastlane-community:master Mar 5, 2022
@manicmaniac manicmaniac mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees

@joshdholtz joshdholtz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xccov_file_direct_path cannot treat with multiple files
3 participants
@manicmaniac @joshdholtz @ryanbourneuk