This repository has been archived by the owner on Nov 19, 2018. It is now read-only.
This should address the issues described in [https://github.com/fastlane/match/issues/42] #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hile decrypting * Asks for old password when changing password and set's it to from variable. These fixes addresses issues when changing your repo password when the former files weren't encrypted properly
KrauseFx
added a commit
that referenced
this pull request
Jan 1, 2016
This should address the issues described in [#42]
|
Thanks, that's great 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fixing [https://github.com//issues/36] I supplied a check in the crypt method, that a password may not be empty. That was fatal for the case, when you wanted to change your password and the former password was empty.
I modified this now and the user will be warned only when an empty password was supplied for encryption. Decryption will now accept an empty password. This addresses the issues in [https://github.com//issues/42].
When changing passwords, the update method asks only for the new password. And since no empty password could be supplied - as mentioned above, the password could not be changed.
I modified the update method slightly to ask not only for the new, but also for the old password. This might be a pain when a correct password was used earlier and it is stored in the keychain. But, for the case when no password was used for en- and decryption, this might be the only way to change your repo-password.