Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

Add command line argument to disable alpha removal #20

Closed
vytis opened this issue Nov 20, 2014 · 6 comments
Closed

Add command line argument to disable alpha removal #20

vytis opened this issue Nov 20, 2014 · 6 comments
Assignees

Comments

@vytis
Copy link

vytis commented Nov 20, 2014

It is a convenient feature when generating screenshots for app submission, but it is not needed when creating them for UI testing. At the moment I am always Ctrl+C'ing after the last screenshot is made...

@KrauseFx
Copy link
Collaborator

Does this take so long? It's just 10 seconds for ~50 screenshots maybe. Recently I changed it so the alpha gets removed after each set of screenshots (simulator change, language change)

Does this still bug you. I think adding a flag or option just to save some seconds on your continuous integration machine or your local computer might not be worth the trouble.

What are your thoughts?

@vytis
Copy link
Author

vytis commented Nov 20, 2014

Just checked on my setup - 1st gen retina MBP. One device (iPad) with 16 screenshots takes 12 seconds. At the moment our app supports 13 languages and 5 different devices (all iPhones + iPad). The screenshots dir is about 750mb... Didn't wait for it to finish, but I presume it will take quite some time.

I guess the main reason I'm thinking about these issues is because I'm using snapshot for UI testing, not for generating screenshots for iTunes Connect. I want to run the test suite as often as possible and any time shaved from it is very useful.

@KrauseFx
Copy link
Collaborator

Makes sense.

@KrauseFx KrauseFx self-assigned this Nov 20, 2014
@KrauseFx
Copy link
Collaborator

Here we go: cae96a2

Just add skip_alpha_removal to your Snapfile

Let me know if that works as expected.

@vytis
Copy link
Author

vytis commented Nov 21, 2014

Yes works perfect!

@fastlanebot
Copy link

This issue was migrated to fastlane/fastlane#2730. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀

@fastlane-old fastlane-old locked and limited conversation to collaborators Mar 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants