Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

Spaceship will always failed after I changed my account password #62

Closed
siuying opened this issue Jul 7, 2015 · 10 comments
Closed

Spaceship will always failed after I changed my account password #62

siuying opened this issue Jul 7, 2015 · 10 comments
Labels

Comments

@siuying
Copy link

siuying commented Jul 7, 2015

After I changed my password, running fastlane always result in error:

[15:49:10]: fastlane finished with errors
/Users/siuying/.rvm/gems/ruby-2.1.5/gems/spaceship-0.0.14/lib/spaceship/client.rb:176:in `login': #<Faraday::Response:0x007fad7bb6d9d0> (Spaceship::Client::InvalidUserCredentialsError)
    from /Users/siuying/.rvm/gems/ruby-2.1.5/gems/spaceship-0.0.14/lib/spaceship/client.rb:45:in `login'
    from /Users/siuying/.rvm/gems/ruby-2.1.5/gems/spaceship-0.0.14/lib/spaceship.rb:31:in `login'
    from /Users/siuying/.rvm/gems/ruby-2.1.5/gems/sigh-0.10.0/lib/sigh/spaceship/runner.rb:11:in `run'
    from /Users/siuying/.rvm/gems/ruby-2.1.5/gems/sigh-0.10.0/lib/sigh/manager.rb:7:in `start'
    from /Users/siuying/.rvm/gems/ruby-2.1.5/gems/fastlane-1.7.0/lib/fastlane/actions/sigh.rb:20:in `run'

I expect spaceship to ask me to enter new password, but it just crash.

Manually delete the entry 'fastlane." can workaround the issue.

Moved from: fastlane/fastlane#390

@KrauseFx
Copy link
Contributor

KrauseFx commented Jul 7, 2015

I'm not 100% sure how to solve this: If spaceship were to remove the password from the Keychain it means, the user gets asked for the password next time. That's okay, but it's a big problem on Continuous Integration system, where there must not be any user interaction.

@snatchev what do you think about this?

@siuying
Copy link
Author

siuying commented Jul 8, 2015

The main problem here is there is no UI to update or remove the credential. Maybe a command line option to force new login?

I also noticed that in credentials_manager gem, there is logic to ask for new password if the one provided is wrong. (https://github.com/fastlane/credentials_manager/blob/master/lib/credentials_manager/password_manager.rb#L51)

@mikefranken
Copy link

The key to search for in KeyChain start with deliver. BTW

@tabuchid
Copy link

tabuchid commented Oct 8, 2015

I also just ran into this. I think at the very least exposing a command to remove/change your password would be helpful.
Also a message telling you what to do instead of a crash in this instance.

@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 8, 2015

@tabuchid
Copy link

tabuchid commented Oct 8, 2015

@KrauseFx Thank you! That ended up fixing it for me.
Moving forward documentation is a good first step but what do you think about catching the error and displaying a message pointing people at the instructions to clear the keychain?
Beyond that should this tool have a option to reset/clear/change the stored password?

@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 9, 2015

@tabuchid I agree with you. I was also briefly chatting with @snatchev about this. AFAIK it's not possible to detect the difference between an iTC/Dev Portal server error (which happens often) and an invalid username/password combination.

If you use a tool like deliver or pilot it will actually tell you the password is invalid and even reset it for you. That's possible because it knows the password was invalid.

I'd have to further investigate if it's possible to make sure the login failed because of an invalid password. The password manager of fastlane already supports showing the message + offering to reset the password.

@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 9, 2015

@KrauseFx KrauseFx closed this as completed Oct 9, 2015
@KrauseFx
Copy link
Contributor

KrauseFx commented Oct 9, 2015

Please let me know if that works for you 👍

@fastlanebot
Copy link

This issue was migrated to fastlane/fastlane#3547. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀

@fastlane-old fastlane-old locked and limited conversation to collaborators Mar 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants