Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constant Deprecate warning on Ruby 2.5 #6

Merged
merged 3 commits into from Feb 15, 2018
Merged

Remove constant Deprecate warning on Ruby 2.5 #6

merged 3 commits into from Feb 15, 2018

Conversation

giginet
Copy link

@giginet giginet commented Feb 14, 2018

screen shot 2018-02-14 at 16 37 42

I ran rubocop for fastlane main repo on Ruby 2.5. However, warnings are raised from this gem.

This is a forked version of commander-rb. So, I cherry-picked patches from the original repo.

commander-rb#62
commander-rb#63

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

giginet
giginet commented Feb 14, 2018
View reviewed changes
lib/commander/version.rb
@@ -1,3 +1,3 @@
module Commander
VERSION = '4.4.5'.freeze
VERSION = '4.4.6'.freeze
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I bump up version?

@giginet
Copy link
Author

giginet commented Feb 14, 2018

CI is fallen because of CLA...
Should I do?

KrauseFx
KrauseFx approved these changes Feb 14, 2018
View reviewed changes
Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. It's your choice on the version bump, I think it's fine 👍

Is this ready to be merged, and pushed to RubyGems?

@giginet
Copy link
Author

giginet commented Feb 15, 2018

Sure. Can I push to RubyGems?

@giginet
Copy link
Author

giginet commented Feb 15, 2018 •
edited

It seems I don't have merge privileges in this repo.

@KrauseFx KrauseFx merged commit 73982b2 into fastlane:master Feb 15, 2018
@KrauseFx
Copy link
Member

Perfect, thanks. I pushed it up. Should we update the fastlane.gemspec also?

@KrauseFx
Copy link
Member 

Pushing gem to https://rubygems.org...
Repushing of gem versions is not allowed.
Please use `gem yank` to remove bad gem releases.

@KrauseFx
Copy link
Member

whops, need another version bump I guess

@KrauseFx
Copy link
Member

Uh, that's weird, the game was renamed..

@KrauseFx
Copy link
Member

Ah I was using the wrong remote

@KrauseFx
Copy link
Member

Alright, live now 👍

@giginet giginet deleted the support-2.5 branch February 15, 2018 04:57
@giginet giginet mentioned this pull request Feb 15, 2018
Merged
4 tasks
@giginet
Copy link
Author

giginet commented Feb 15, 2018

Did it! fastlane/fastlane#11848

Don't you also need to create GitHub release?

@KrauseFx
Copy link
Member

Thanks, we don't need a new GitHub release for this gem

@ainame ainame mentioned this pull request Apr 28, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrauseFx KrauseFx KrauseFx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@giginet @googlebot @KrauseFx @ggilder