Disable submit for review

[DenTelezhkin]

It would be nice if we had an option to disable immediate submission for review. It's always nice to walk through all information to check it before pushing scary red button, that will take 5-10 days on the App Store review team side.

I searched through documentation and didn't find it. Do you have such option in plans or implemented?

[KrauseFx]

That's a good point and makes perfectly sense.
Right now, you can just comment out the ipa line.

I'll add an option for this later today, thanks for letting me know.

[KrauseFx]

@paweldudek seems to have implemented something like this already: https://github.com/paweldudek/deliver/commit/2a58241243513ba0dfda187332fad16e81391cf8

About the scary red button: You know you can very easily cancel the submission while Waiting for Review?

[DenTelezhkin]

@KrauseFx Yep, of course, but it's strange to cancel submission every time. At least for me, i would never want automatic submission for review, but it's very subjective, of course.

Anyway, thanks for great gem, it's a great addition to our build tools!

[KrauseFx]

@DenHeadless Yes, I understand that.
I'll be working together with @paweldudek to implement this feature.

[paweldudek]

@DenHeadless @KrauseFx should be able to bake a PR for this one tomorrow 😉

[KrauseFx]

Awesome, thanks @paweldudek. As mentioned on your commit: It's okay to just send a PR with the new option in the ipa_uploader. I'll implement the interface of the Deliverfile and update the README.

[mgrebenets]

Good to see progress on this request.

I just used deliver to upload an app and was puzzled when I realized that the ipa was actually submitted for review, not just uploaded.

For me the main concern was how did deliver answer the compliance questions. The one about encryption and another one about IDFA. For IDFA there's yes/no option and then 3 checkboxes of which I have to check only the first one, then there's "I contest" checkbox at the bottom.

It would be a nice improvement to have these answers configurable in Deliverfile.

And finally deliver could be used to upload ipa and then share it with beta testers via TestFlight.

P.S.
Thanks for an awesome gem! Keep up good work!

[KrauseFx]

@mgrebenets

Both things you mentioned are possible:

• Compliance Questions
• TestFlight

I have to admit, I'm not sure the Compliance Questions are working. You can create a separate issue in case it's not working.

[mgrebenets]

Cool, thanks for the links.
Right, there's no way to check compliance questions answers once the app is submitted for review, at least I can't find anything in iTC.

Probably taking screenshots of browser page with answers could be a valuable feature. To serve as reassurance for concerned developers.

[KrauseFx]

Do you mean deliver should take a screenshot of all opened pages and store them somewhere?

A screenshot of all available options can be found here.

[mgrebenets]

No, I don't mean to screenshot all the pages, just important ones. Like that page with answers to compliance questions.

[KrauseFx]

This functionality is now available in the master branch: #36

Please take a look at the bottom comments about how to install it. The new version was not yet released, still waiting for an okay from the other developers.

[DenTelezhkin]

Thank you very much!

[KrauseFx]

Can you try it and let me know if it works as expected?

[fastlanebot]

This issue was migrated to fastlane/fastlane#2458. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀