Replies: 1 comment
-
I encountered the same problem, and up to this point, it remains consistent with what Parabak mentioned. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey guys,
From my point of view current
upload_screenshots
implementation indeliver
action is ambiguous.Let's consider the case when I want to upload & overwrite screenshots for one particular locale e.g.
en-GB
.p.s. This option is vital In case you have ~1k screenshots you don't want to reupload them all as it took time and is failing from time to time due to AppStore issues
I set
overwrite_screenshots: true
and run deliver:DeleteScreenshotSetJob
is enqueued for locales that are gonna be changed (in our case it's en-GB), which is nice.Once worker is finished all screenshots from
en-GB
are deleted 👍However, right after that, there is a check for all undeleted screenshots
Voila, we have N screenshots undeleted — exit with error code.
... INFO [2022-11-15 15:04:37.40]: Deleted 'en-GB APP_IPAD_PRO_3GEN_129' - (2.304244 secs) WARN [2022-11-15 15:04:47.33]: Number of screenshots not deleted: 686 ERROR [2022-11-15 15:04:47.33]: Failed to delete all screenshots... Tries remaining: 4 ...
I suggest to
overwrite_screenshots
with someenum: all, selected
whereall
screenshots are deleted only for all Store locales versions. Deletion is verifiedselected
screenshots are deleted only for locales fromscreenshots_path
. Deletion is verified only for those locales (not all)The workaround I'm using now:
All screenshots from required locales are deleted, but the action is failed. Repeast with
overwrite_screenshots
to just uploaded these locales 🤷Beta Was this translation helpful? Give feedback.
All reactions