[resign] Enhance Display Name Handling: Add CFBundleDisplayName if Missing #21827
Unanswered
raphschwander
asked this question in
Ideas
Replies: 1 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In the resign action documentation, the display_name parameter is mentioned as the "Display name to force resigned IPA to use."
However, the current implementation has limitations when the CFBundleDisplayName is missing in the Info.plist.
I propose enhancing the code to support the case where the key is missing. The following modification to the resign.sh script will always set CFBundleDisplayName property, also when it's missing:
From
fastlane/sigh/lib/assets/resign.sh
Lines 465 to 471 in 39ed6fe
To
This modification ensures that the display name is updated or added during the resigning process, providing a more flexible and robust solution.
What do you think ?
Beta Was this translation helpful? Give feedback.
All reactions