Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MiniMagick to 4.9.0 #13410

Closed
janpio opened this issue Sep 21, 2018 · 8 comments
Closed

Update MiniMagick to 4.9.0 #13410

janpio opened this issue Sep 21, 2018 · 8 comments

Comments

@janpio
Copy link
Member

janpio commented Sep 21, 2018

https://github.com/minimagick/minimagick/releases/tag/v4.9.0

Supports ImageMagick 7, which moved some things around.
Should probably check commands used here in code as well.

@fastlane-bot

This comment has been minimized.

@janpio

This comment has been minimized.

@sorianog

This comment has been minimized.

@janpio

This comment has been minimized.

@janpio
Copy link
Member Author

janpio commented Sep 28, 2018

Found a code comment in one of my WIP branches that is relevant here:

      ...
      @image = MiniMagick::Image.open(screenshot.path)
      # TODO This throws "ImageMagick/GraphicsMagick is not installed" on Windows if no ImageMagick is installed
      # This should be handled better somehow - maybe during `frameit` loading/startup check already if MiniMagick is happy?
      # Install ImageMagick 6 (!)
      # https://legacy.imagemagick.org/script/download.php#windows
      # Install ImageMagick 7 and set checkbox "Install legacy utilities (e.g. convert)" during installation
      # https://imagemagick.org/script/download.php#windows

Source: frameit\lib\frameit\editor.rb

@fastlane-bot
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@fastlane-bot
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@fastlane-bot
Copy link

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants