New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFBundleShortVersionString changes to git branch name causing ERROR ITMS-90060 #13427
Comments
It seems like this issue might be related to code signing 🚫 Have you seen our new Code Signing Troubleshooting Guide? It will help you resolve the most common code signing issues 👍 |
It seems like you have not included the output of To make it easier for us help you resolve this issue, please update the issue to include the output of |
@LyndseyScott Looking into! 💪 |
@LyndseyScott Heyyy 👋 Are you able to send me what you use to change the branch during your build process so that I can try to replicate this on my side? 😊 |
@joshdholtz As far as I know, I’m not changing the branch during my build process... When I do change branches though I use the command |
@LyndseyScott Oops, sorry! I meant Do you have a "Run Script" similar to this? buildNumber=$(git rev-parse --abbrev-ref HEAD)
/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString $buildNumber" "${PROJECT_DIR}/${INFOPLIST_FILE}" I added something like this to my sample project ^ This upload to App Store Connect worked for me 🤔 This set my What value do you get if you run this? /usr/libexec/PlistBuddy -c "Print :CFBundleShortVersionString" /Your/Project/Path/Info.plist Thanks! |
@LyndseyScott Another question... Do you happen to have a pod/dependency that has a wrongly formatted version in it? Something similar to this stackoverflow question - https://stackoverflow.com/a/33375436/2464643 |
@joshdholtz Ah, yes! That build script is probably the issue:
The pods/dependencies all have properly formatted versions. |
@joshdholtz Feel free to send along any feedback, but I think I should be able to fix things on my own from here... (The version’s clearly being pulled from the git repo. 🤦♀️) Thanks so much for directing me to this build script issue! |
@LyndseyScott Not a problem! Also, which plist library is this? I'm getting a |
@joshdholtz Actually, it looks as if plist is a file (below) that builds off of PListBuddy. (This part of the project was built before I came on board.)
|
@LyndseyScott Ahhh, that makes sense why I couldn't find anything that matched that module name! I don't know if your run script does anything else but are you able to replace this with something like the run script I had above that was just a few shell commands? Just thinking it might be easier in the future for maintenance and if/when other developers get onboarded 😊
|
@joshdholtz Thanks for the suggestion! I’ll definitely incorporate something like that into the changes I’m about to make. |
@LyndseyScott Sounds good! Let me know if you need anything else 👌 And feel free to DM me on Twitter (https://twitter.com/joshdholtz) if you need anything fastlane related or an issue bumped. I try to look at all the issues that come in but sometimes I miss some 🙃 And also, I'm a fan of your work on raywenderlich.com! Loved the fastlane tutorial ❤️ |
@joshdholtz Thanks! I wouldn’t be surprised if that fastlane tutorial needs an update at this point... I definitely want to create a version of the tutorial that shows how to support multiple targets. Hope to get around to that soon. |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest |
This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍 |
New Issue Checklist
Issue Description
My build’s CFBundleShortVersionString changes to the project’s current git branch name during the app build process thus causing the following error:
I know that the CFBundleShortVersionString is in fact being pulled from the current git branch name, because when I change that git branch name and rerun the lane, the above error reflects that git branch name change.
Also note that I print the version number ("--- Step: get_version_number ---" ... "5.0") before and after building the iOS app ("--- Step: build_ios_app ---") and both times
get_version_number
produces "5.0" as desired.Complete output when running fastlane, including the stack trace and command used
Environment
The text was updated successfully, but these errors were encountered: