Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapshotHelper does not pass SwiftLint checks #13658

Closed
4 tasks done
bes opened this issue Nov 8, 2018 · 5 comments
Closed
4 tasks done

SnapshotHelper does not pass SwiftLint checks #13658

bes opened this issue Nov 8, 2018 · 5 comments

Comments

@bes
Copy link
Contributor

bes commented Nov 8, 2018

New Issue Checklist

Issue Description

The generated SnapshotHelper.swift file contains superfluous whitespaces which causes SwiftLint to issue trailing_whitespace warnings.

A simple fix would be to run SwiftLint or a similar tool to catch linting errors before submitting a new SnapshotHelper to fastlane.

Complete output when running fastlane, including the stack trace and command used

Not applicable

Environment

Not applicable

Thank you for considering my humble "bug report".

@fastlane-bot
Copy link

It seems like you have not included the output of fastlane env

To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env 👍

@bes
Copy link
Contributor Author

bes commented Nov 9, 2018

Thanks mr @fastlane-bot but I really don't think it's needed 👍 ❤️🐶

@janpio
Copy link
Member

janpio commented Nov 18, 2018

Thanks for the report @bes. Are you up to creating a PR that fixes the current problems? Additionally, maybe even a PR that adds the mentioned tools to the CI setup? (That might be a bit more involved though...)

@fastlane-bot
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@fastlane-bot
Copy link

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍

@fastlane fastlane locked and limited conversation to collaborators Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants