New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exact file format specs for text files synced from Google Play? #14251
Comments
Data is downloaded here: fastlane/deliver/lib/deliver/setup.rb Lines 43 to 45 in 39e3f9b
And then written to files here: fastlane/deliver/lib/deliver/setup.rb Lines 59 to 128 in 39e3f9b
Lets focus on one specific example: fastlane/deliver/lib/deliver/setup.rb Lines 65 to 73 in 39e3f9b
First it gets the data. Then it adds a \n at the end, and writes the result to the file.
So my guess: The API returns a trimmed string, fastlane/ You should be able to confirm by testing this with your own apps. Best also try to add a few empty lines at the description for example - my guess is that Google strips those when saving anyway so the API always returns trimmed values. |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest |
This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍 |
Question Checklist
Question Subject
Weblate has implemented support for the native Fastlane text files so the can be easily translated. Weblate is based on git repos, so whitespace changes can cause merge conflicts and unnecessary noise. So it is important to minimize whitespace changes as much as possible for a smooth, automated workflow. Towards that end, we'd like to know more about how Fastlane handles the text files so that Weblate does the same thing. Is there a canonical format for title.txt, summary.txt, etc. regarding leading and trailing spaces? Does fastlane write out title.txt, summary.txt, etc. based on the data from Google Play without modifying it? Does anyone know if submitting to Google Play, then fetching from Google Play will strip whitespace?
For more info:
WeblateOrg/weblate#1525 (comment)
@janpio @nijel
The text was updated successfully, but these errors were encountered: