Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] add trim_mode to erb action #16869

Closed
joshdholtz opened this issue Jul 16, 2020 · 1 comment 路 Fixed by #16882
Closed

[feature request] add trim_mode to erb action #16869

joshdholtz opened this issue Jul 16, 2020 · 1 comment 路 Fixed by #16882
Labels
complexity: you can do this tool: action type: feature

Comments

@joshdholtz
Copy link
Member

Initial discussion 馃憠 #16867

Feature Request

  • Add trim_mode option to the erb action
  • Potentially look into replacing erb action logic with ErbTemplateHelper
    • ErbTemplateHelper already has support for trim_mode
@joshdholtz joshdholtz changed the title [feature request] [feature request] add trim_mode to erb action Jul 16, 2020
@fastlane fastlane deleted a comment from fastlane-bot Jul 17, 2020
@joshdholtz joshdholtz mentioned this issue Jul 17, 2020
Merged
@fastlane-bot
Copy link

The pull request #16882 that closed this issue was merged and released as part of fastlane 2.153.0 馃殌
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

@fastlane fastlane locked and limited conversation to collaborators Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
complexity: you can do this tool: action type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[action] erb uses ErbTemplateHelper and adds trim mode fastlane/fastlane
2 participants
@joshdholtz @fastlane-bot