sh spamming our logs upon errors by getting the output printed 3 times

[tutipeti]

New Issue Checklist

• Updated fastlane to the latest version
• I read the Contribution Guidelines
• I read docs.fastlane.tools
• I searched for existing GitHub issues

Issue Description

We are using Unity during our build process, called from fastlane. Unity is already log-heavy on its own, but when a build fails fastlane (and bundler) makes it worse by triplicating the output, making it harder to spot actual issues in the enormous logs we receive at the end on CI.

The problem seems to be the following:

1. sh is logging the output line by line as it happens (see here)
2. if the exit code is non-zero, the whole output is repeated (see here)
3. on default an exception is raised, which is then picked up by bundler, and I guess bundler decides to also repeat the whole output (see here)

The only improvement I see we can do already is passing an error_callback in, which would at least result in no exception being thrown, so hopefully at least bundler wouldn't step in anymore. That still means that the entire output is printed twice 🤷

Searching for previous issues gave me this #11140, reported by @janpio himself ;)
However, the problem for us is that the resolution from that issue, setting print_command_output to false and with that swallowing the output is not really a feasible option, as we'd like to be able to see the output on-the-fly from Unity to be able to detect potential problems.

As for potential solutions: in my opinion 2) is unnecessary, and should either be removed completely, or at least be controlled by an extra parameter to that method.

I know this sounds a bit like a feature request, but I'm happy to change the lines in question if I get any input on which solution is preferred by you guys.

Cheers,
Peter

[fastlane-bot]

It seems like you have not included the output of fastlane env
To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env 👍

[Olson227]

I have to admit that you have shown a great insperation in this wonderful site. I understood that we should teach a tactical approach in every learning opportunity that we received even in our own ways of learning before teaching technical skills and showing the result to others to come up for successful and contented result and through this i was able to modify each poject that i have specialy this one for u >> Thanks !!

Prepaid Card Status

[fastlane-bot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

[tutipeti]

The issue is still there, I'm waiting for a reply on the PR.

[fastlane-bot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

[tutipeti]

Waiting for the PR, issue is still valid.

[fastlane-bot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

[tutipeti]

Waiting for the PR, issue is still valid.

[fastlane-bot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

[fastlane-bot]

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍

[rogerluan]

Sorry this issue got auto-closed @tutipeti ! I love this initiative, and I'll continue discussion in the PR :)
This PR won't be auto-closed anymore 🙇