Match doesn't respect team_id when readonly is true.
#20635
Comments
|
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with This issue will be auto-closed if there is no reply within 1 month. |
|
This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍 |
New Issue Checklist
Issue Description
In a setup where you have an S3 bucket (
someS3Bucket) with multiple teams:team1andteam2. Runningmatch(team_id: 'team1', readonly: true, storage: 's3', bucket: 'someS3Bucket')will try to download certificates and profiles for bothteam1andteam2.I expected
matchto only download certificates and profiles fromteam1. The fact that it is downloading all certificates and provisioning profiles makes it quite hard to restrict access to certificates and profiles based onteam_id. In the command output below, I am using the accessKeyId and secretAccessKey from a user, who only has read access toteam1.The reason I know fastlane is trying to download every file, is because I added a
putsstatement in~/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/customizations/object.rbline 478:Command executed
match(team_id: 'team1', readonly: 'true', storage: 's3', bucket: 'someS3Bucket')Complete output when running fastlane, including the stack trace and command used
match(type: "development", storage_mode: 's3', app_identifier: ["com.some.app"], s3_region: "eu-west-1", s3_bucket: "someS3Bucket", s3_access_key: "SOMEACCESSKEYID", s3_secret_access_key: *********, team_id: "team1", readonly: true, skip_certificate_matching: true) [✔] 🚀 [13:46:51]: fastlane detected a Gemfile in the current directory [13:46:51]: However, it seems like you didn't use `bundle exec` [13:46:51]: To launch fastlane faster, please use [13:46:51]: [13:46:51]: $ bundle exec fastlane certificates [13:46:51]: [13:46:51]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile [13:46:52]: Driving the lane 'certificates' 🚀 [13:46:52]: ------------------- [13:46:52]: --- Step: match --- [13:46:52]: -------------------+----------------------------------------+--------------------------------------------------------+
| Summary for match 2.209.1 |
+----------------------------------------+--------------------------------------------------------+
| type | development |
| storage_mode | s3 |
| app_identifier | ["com.some.app"] |
| s3_region | eu-west-1 |
| s3_bucket | someS3Bucket |
| s3_access_key | SOMEACCESSKEYID |
| s3_secret_access_key | ******** |
| team_id | team1 |
| git_branch | master |
| readonly | true |
| skip_certificate_matching | true |
| generate_apple_certs | true |
| skip_provisioning_profiles | false |
| shallow_clone | false |
| clone_branch_directly | false |
| skip_google_cloud_account_confirmation | false |
| keychain_name | login.keychain |
| force | false |
| force_for_new_devices | false |
| include_all_certificates | false |
| force_for_new_certificates | false |
| skip_confirmation | false |
| safe_remove_certs | false |
| skip_docs | false |
| platform | ios |
| derive_catalyst_app_identifier | false |
| fail_on_name_taken | false |
| skip_set_partition_list | false |
| verbose | false |
+----------------------------------------+--------------------------------------------------------+
+---------------+--------------+
| Lane Context |
+---------------+--------------+
| PLATFORM_NAME | |
| LANE_NAME | certificates |
+---------------+--------------+
[13:46:53]: Aws::S3::Errors::Forbidden
+------+--------+-------------+
| fastlane summary |
+------+--------+-------------+
| Step | Action | Time (in s) |
+------+--------+-------------+
| 💥 | match | 0 |
+------+--------+-------------+
[13:46:53]: fastlane finished with errors
Looking for related GitHub issues on fastlane/fastlane...
➡️ Match receives
Access Forbiddenresponse#20530 [open] 1 💬
3 days ago
➡️ fastlane init failed - undefined method `include?' for nil:NilClass
#20457 [open] 3 💬
4 weeks ago
➡️ Verifying that the certificate and profile are still valid on the Dev Portal... Reading keychain entry, because either user or password were empty
#20416 [closed] 4 💬
a week ago
and 24 more at: https://github.com/fastlane/fastlane/search?q=Aws%3A%3AS3%3A%3AErrors%3A%3AForbidden&type=Issues&utf8=✓
🔗 You can ⌘ + double-click on links to open them directly in your browser.
'/Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/seahorse/client/plugins/raise_response_errors.rb:17:in
call': \e[31m[!] Aws::S3::Errors::Forbidden\e[0m (Aws::S3::Errors::Forbidden) from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/plugins/sse_cpk.rb:24:incall'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/plugins/dualstack.rb:27:in
call' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/plugins/accelerate.rb:56:incall'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/plugins/checksum_algorithm.rb:111:in
call' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/plugins/jsonvalue_converter.rb:16:incall'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/plugins/idempotency_token.rb:19:in
call' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/plugins/param_converter.rb:26:incall'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/seahorse/client/plugins/request_callback.rb:71:in
call' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/plugins/response_paging.rb:12:incall'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/seahorse/client/plugins/response_target.rb:24:in
call' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/seahorse/client/request.rb:72:insend_request'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/client.rb:7232:in
head_object' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/file_downloader.rb:56:inmultipart_download'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/file_downloader.rb:36:in
download' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/customizations/object.rb:481:indownload_file'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/customizations/object_summary.rb:80:in
download_file' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/match/lib/match/storage/s3_storage.rb:113:inblock in download'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:54:in
yield' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:54:inblock (3 levels) in each'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:53:in
each' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:53:inblock (2 levels) in each'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:102:in
yield' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:102:inblock (2 levels) in non_empty_batches'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/bucket.rb:923:in
yield' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/bucket.rb:923:inblock (2 levels) in objects'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/pageable_response.rb:191:in
each' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-s3-1.114.0/lib/aws-sdk-s3/bucket.rb:913:inblock in objects'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:101:in
each' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:101:ineach'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:101:in
block in non_empty_batches' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:52:ineach'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:52:in
each' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:52:inblock in each'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:58:in
each' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:58:ineach'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/aws-sdk-core-3.132.0/lib/aws-sdk-core/resources/collection.rb:58:in
each' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/match/lib/match/storage/s3_storage.rb:104:indownload'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/match/lib/match/runner.rb:65:in
run' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/actions/sync_code_signing.rb:19:inrun'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/runner.rb:263:in
block (2 levels) in execute_action' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/actions/actions_helper.rb:69:inexecute_action'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/runner.rb:255:in
block in execute_action' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/runner.rb:229:inchdir'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/runner.rb:229:in
execute_action' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/runner.rb:157:intrigger_action_by_name'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/fast_file.rb:159:in
method_missing' from Fastfile:27:inblock in parsing_binding'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/lane.rb:33:in
call' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/runner.rb:49:inblock in execute'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/runner.rb:45:in
chdir' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/runner.rb:45:inexecute'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/lane_manager.rb:47:in
cruise_lane' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/command_line_handler.rb:36:inhandle'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/commands_generator.rb:110:in
block (2 levels) in run' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/commander-4.6.0/lib/commander/command.rb:187:incall'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/commander-4.6.0/lib/commander/command.rb:157:in
run' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/commander-4.6.0/lib/commander/runner.rb:444:inrun_active_command'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:124:in
run!' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/commander-4.6.0/lib/commander/delegates.rb:18:inrun!'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/commands_generator.rb:354:in
run' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/commands_generator.rb:43:instart'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/fastlane/lib/fastlane/cli_tools_distributor.rb:123:in
take_off' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/gems/fastlane-2.209.1/bin/fastlane:23:in<top (required)>'from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/bin/fastlane:25:in
load' from /Users/vvf/Applications/homebrew/Cellar/fastlane/2.209.1/libexec/bin/fastlane:25:inEnvironment
✅ fastlane environment ✅
Stack
System Locale
fastlane files:
No Fastfile found
No Appfile found
fastlane gems
Loaded fastlane plugins:
No plugins Loaded
Loaded gems
generated on: 2022-09-08
The text was updated successfully, but these errors were encountered: