[trainer] report run destination as testsuite properties #20966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
When running fastlane over multiple destinations (aka, devices and OS versions) it's impossible to know in the final report which destination failed.
Description
The information about the destination is already available in the xcresult bundle, but it was ignored during the parsing. This PR introduces the basic types and hooks them into the parsing flow.
That allow the action type to have access to the test suites (
test_ref
) and the run_destination. However, the code needed refactoring as it was processing everything in batch ignoring on what test suite it belonged to. Thus, the code was refactor to process each test suite as a single unit, allowing to pass the run destination information along.Then the template was updated to reflect the new properties in the test suite if they are available.
Testing Steps
All unit tests and fixtures were updated to reflect the new changes.