Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trainer] report run destination as testsuite properties #20966

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kronenthaler
Copy link
Contributor

@kronenthaler kronenthaler commented Jan 5, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

When running fastlane over multiple destinations (aka, devices and OS versions) it's impossible to know in the final report which destination failed.

Description

The information about the destination is already available in the xcresult bundle, but it was ignored during the parsing. This PR introduces the basic types and hooks them into the parsing flow.
That allow the action type to have access to the test suites (test_ref) and the run_destination. However, the code needed refactoring as it was processing everything in batch ignoring on what test suite it belonged to. Thus, the code was refactor to process each test suite as a single unit, allowing to pass the run destination information along.
Then the template was updated to reflect the new properties in the test suite if they are available.

Testing Steps

All unit tests and fixtures were updated to reflect the new changes.

@google-cla
Copy link

google-cla bot commented Jan 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kronenthaler
Copy link
Contributor Author

Any reviewers for this feature?

@kronenthaler kronenthaler force-pushed the trainer-report-destination-as-testsuite-properties branch from 7ce49e2 to 5ba619f Compare October 5, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants