Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] (Duplicate) When there is at least 1 framed screenshot, all non-framed screenshot files are skipped, even for devices that have no framed screenshots #22048

Open
ricsantos opened this issue May 24, 2024 · 1 comment

Comments

@ricsantos
Copy link

Reopening #15366 as I hit this issue today.

I frame the iPhone screenshots, but not the iPad screenshots.

However, deliver doesn't detect or upload the iPad screenshots because it can see framed ones exist.

Framed screenshots are detected! 🖼 Non-framed screenshot files may be skipped. 🏃

Would be great if it uploaded the iPad screenshots... seems the workaround is to upload in two batches, iPhone and iPad.

Cheers and thanks for the most awesome timesaving set of tools 🙏!

@ricsantos
Copy link
Author

ricsantos commented May 24, 2024

For those playing at home, my workaround was to rename all the iPad screenshots to have a _framed suffix.

Here's the bash script:

#!/bin/bash

echo "Renaming iPad Pro screenshots to iPad Pro _framed"

find . -type f -name 'iPad Pro*.png' | while read FILE ; do
    if [[ $FILE != *_framed.png ]]; then
        NEWFILE="${FILE/.png/_framed.png}"
        echo "Renaming ${FILE} to ${NEWFILE}";
        mv "${FILE}" "${NEWFILE}";
    else 
        echo "Skipping ${FILE} as it already ends in _framed.png"
    fi
done 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant