Use of legacy DELIVER_* in password_manager.rb

[fastlanebot]

Original issue by @timsutton - Imported from fastlane/credentials_manager#21

I'm doing some testing with the 1.1.0 gem release of XcodeInstall, which uses CredentialsManager 0.10.0.

The CredentialsManager docs mention to set the new FASTLANE_* variables, but in password_manager.rb there is still the use only of DELIVER_*. As far as I can tell, I still get a prompt if PasswordManager is initialized with only the FASTLANE_* vars set.

[fastlanebot]

@KrauseFx commented

@timsutton The PasswordManager isn't used anywhere any more and also shouldn't be used by XcodeInstall.

[fastlanebot]

@KrauseFx commented

FASTLANE_* should work just fine

[fastlanebot]

@timsutton commented

You're right, it doesn't use this directly - XcodeInstall uses Spaceship. It looked to me like in my testing that if I didn't have DELIVER_* vars set, that I would get a keychain-related prompt that was blocking a CI environment build script that I'm testing. When I didn't get the prompt upon replacing FASTLANE_* with DELIVER_* I assumed this was the reason. I'll have to go back and test this again. The fastlane "ecosystem" is all very new to me.

[fastlanebot]

@KrauseFx commented

Okay cool 👍

[fastlanebot]

@KrauseFx commented

Thanks for letting me know @timsutton