New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Important] Improve passing of parameters for all tools #45
Comments
This would result in one class of each tool, defining all available options, with a short description of what they're for. We then iterate through all available options and pass it to |
I'm finding this to be particularly important with sigh, as it'd be great to be able to specify the file name and output directory from within fastlane when fetching provisioning profiles. |
I completely agree. Any feedback appreciated! I want to get this right when working on this issue. |
I've just started diving into developing a pipeline with fastlane, so I don't have the best insight into all use cases yet. With sigh in particular, I'd want to be able to define parameters per lane. The usage that I see would involve updating the sigh action to work with parameters in a similar manner to produce. This would enable me to define the parameters inline to the call, or as environment variables externally first. |
The current plan is to provide a From then on, each tool can call the Thanks @joshdholtz 👍 |
Hello, I think it may be a little late, since we already make a big use of For other information I think we should take from configuration file, fastlane options, and command line arguments (the latter overwrites former). What do you think of this? |
Why wouldn't we also allow passing of any information from the environment? |
I don't know, just think would be nice to have one place of input. |
Also maybe use something like this but generalised for all tools? |
Ok, I'll check out how other established tools ( |
Started with the pull request: fastlane-old/fastlane_core#8 Will take a few more days until fully finished 🚀 |
Everything except for the configuration file is finished 🚀 |
Related to fastlane-old/supply#41: be more verbose about featureGraphic not being downloaded
Add some initial tests to screengrab
Some tools, like
sigh
can only be passed some of the available command like options, not all of them.Also, sometimes users want to have a parameter for a tool, for which there is already an environment variable available (fastlane-old/sigh#45)
There needs to be a more unified way:
There are 5 ways to pass configuration to the individual fastlane tools (ordered):
deliver -u felix@krausefx.com
)fastlane
snapshot
anddeliver
)The user should be able to set every option in all 5 ways.
Any other ideas? Concerns?
The text was updated successfully, but these errors were encountered: