New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of HipChat icon image. #52
Comments
Looking at the code, its width should only be 50px: https://github.com/KrauseFx/fastlane/blob/master/lib/fastlane/actions/hipchat.rb#L30 Maybe @jingx23 can help? |
A quick test seemed to show that the style section of the img tag was not taking effect. I replaced the tag with:
and the image was properly resized with the next message. This isn't as future-proof, since it's explicitly setting the dimensions of the height as well, but does the trick. |
Ah, this is a bit old, but may indicate the issue: https://twitter.com/hipchat/status/309704328229298177 I'll create a pull request with the update. |
I think it's quite odd to just put in HTML code. Thanks for providing a pull request 👍 |
Using the HipChat action, the messages sent include the fastlane icon. This icon is huge and often much larger than the contents of a message, excluding errors with long stack traces. It'd be great to reduce the size of the image used for this to more cleanly fit with more average-sized messages.
The text was updated successfully, but these errors were encountered: