Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of HipChat icon image. #52

Closed
dfranzi opened this issue Feb 17, 2015 · 4 comments
Closed

Reduce size of HipChat icon image. #52

dfranzi opened this issue Feb 17, 2015 · 4 comments

Comments

@dfranzi
Copy link

dfranzi commented Feb 17, 2015

Using the HipChat action, the messages sent include the fastlane icon. This icon is huge and often much larger than the contents of a message, excluding errors with long stack traces. It'd be great to reduce the size of the image used for this to more cleanly fit with more average-sized messages.

fastlane_hipchat_icon

@KrauseFx
Copy link
Member

Looking at the code, its width should only be 50px: https://github.com/KrauseFx/fastlane/blob/master/lib/fastlane/actions/hipchat.rb#L30

Maybe @jingx23 can help?

@dfranzi
Copy link
Author

dfranzi commented Feb 17, 2015

A quick test seemed to show that the style section of the img tag was not taking effect. I replaced the tag with:

<img src=\"https://s3-eu-west-1.amazonaws.com/fastlane.tools/fastlane.png\" width=\"50\" height=\"50\">

and the image was properly resized with the next message. This isn't as future-proof, since it's explicitly setting the dimensions of the height as well, but does the trick.

@dfranzi
Copy link
Author

dfranzi commented Feb 17, 2015

Ah, this is a bit old, but may indicate the issue: https://twitter.com/hipchat/status/309704328229298177

I'll create a pull request with the update.

@KrauseFx
Copy link
Member

I think it's quite odd to just put in HTML code. Thanks for providing a pull request 👍

@dfranzi dfranzi closed this as completed Feb 17, 2015
KrauseFx pushed a commit that referenced this issue Mar 7, 2016
@fastlane fastlane locked and limited conversation to collaborators Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants