Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit existing iTC builds to Review instead of uploading a new one #64

Closed
bassrock opened this issue Feb 19, 2015 · 5 comments
Closed

Comments

@bassrock
Copy link
Contributor

So when looking at the Fastane configuration, i am not sure if it makes sense with the new Apple TestFlight. The new Apple Testflight lets you take a beta build and then make it the live build.

I propose the beta flow uploads the correct metadata for what the new version will be, with the snapshots and all. And then the App Store flow would basically just auto mark the beta upload to be the live version.

Thoughts, ideas?

@KrauseFx
Copy link
Member

I agree, it would make sense to submit the same build for review, which you already had in TestFlight.

How would we approach this? Right now, deliver :testflight will only upload the ipa file, and no metadata or screenshots.

Not sure, if there is a big advantage is submitting the same build?

@bassrock
Copy link
Contributor Author

So i think the deliver :testflight should change so that it does include the metadata, because a test flight push now actually sets up the store page as it would normally.

Then when you do a deliver :appstore all that would happen is you would get a list of all the "active" builds in iTunes Connect that can be submitted and then you select the one to make app store official. This step would basically do no building or uploading, just parsing and letting you pick the option to make official.

@KrauseFx
Copy link
Member

I'm not sure I completely agree. This would also mean, you have to use Apple TestFlight, which many people don't.

@bassrock
Copy link
Contributor Author

Fair point. But I think this workflow situation should be supported. And for those that don't use test flight it should do the same like ur suggesting by using the same build somehow

@KrauseFx KrauseFx changed the title Feature/Idea/Discussion: Workflow Change Submit existing iTC builds to Review instead of uploading a new one Feb 21, 2015
@KrauseFx
Copy link
Member

I'll close this issue for now, thanks for your feedback 👍

KrauseFx added a commit that referenced this issue Mar 7, 2016
Fix typo in Contributing.md file
@fastlane fastlane locked and limited conversation to collaborators Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants