Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add dependencies between actions #67

Closed
KrauseFx opened this issue Feb 21, 2015 · 5 comments
Closed

[Feature] Add dependencies between actions #67

KrauseFx opened this issue Feb 21, 2015 · 5 comments

Comments

@KrauseFx
Copy link
Member

  sigh
  cert

or

  ipa
  sigh

should raise an exception, since it's obviously the wrong order of tools. I think there should be a new command, which you can put on the top of the Fastfile, something like

skip_checking_dependencies

which will not raise an exception (in case you have some complex nested calls)

The exception should be raised when running the script and entering the sigh action, which sees, ipa was already run.

Therefore, fastlane should keep a record of executed commands and store it in the lane context.

@champo
Copy link
Contributor

champo commented Feb 21, 2015

Maybe commands is not the best idea? Since I could have a custom action that does sigh-like things. But rather, require that actions declare their inputs and outputs, and match those?

@almassapargali
Copy link

Maybe just don't care and let commands run in there order user declared. And let it fail if some inputs incorrect, like user wants to create push certificate, but not created app yet, etc. 😈

@KrauseFx
Copy link
Member Author

@almassapargali agree, that's possible the easiest and most stable way. Maybe we should close this issue.

@joshdholtz
Copy link
Member

@KrauseFx I agree. I don't think command dependency is necessary. Sounds like it be over engineering at the moment 😁

@KrauseFx
Copy link
Member Author

Okay, I'll close this issue for now.

KrauseFx added a commit that referenced this issue Mar 7, 2016
This was referenced Mar 8, 2016
@fastlane fastlane locked and limited conversation to collaborators Sep 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants