Add imagemagick as required dependency

[tjosten]

If ImageMagick is not being installed on the system, frameit crashes:

/Library/Ruby/Gems/2.0.0/gems/subexec-0.2.3/lib/subexec.rb:71:in spawn': No such file or directory - identify (Errno::ENOENT)`

[KrauseFx]

What happens if you run which convert in your terminal?

[tjosten]

convert is part of ImageMagick - if ImageMagick is not installed, convert is of course not found.

[KrauseFx]

Yes, I know that!

I implemented a dependency checker: dependency_checker.rb:9

That's why I'm asking, what's the output, when you run which convert. It should be empty. If it is empty, than FrameIt should actually raise an exception telling you to install ImageMagick.

[tjosten]

Thanks for the information. The original issue seems to be that convert was in my PATH for other reasons, but identify wasn't. I suggest probing for all required commands in your dependency checker.

[KrauseFx]

Mh, I'm actually not using identify. I'm only calling convert when converting the screenshots.
I think it wouldn't be a good idea to check for all commands which are used by convert. This would be difficult to maintain.

What do you think?

[tjosten]

Agreed. Maybe you're not explicitly calling `ìdentitfy``, but the library you rely on does. I see the difficulty here.

[KrauseFx]

Alright, I'll close this issue for now. If more people report problems with having convert, but not identify, I'll take a closer look. Thanks for reporting 👍

[fastlanebot]

This issue was migrated to fastlane/fastlane#2790. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀