Fix 2.0 installer script #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey I made some adjustments to your changes for the new installer package. * Add missing `fastlane_shim` file * remove ssl certificate environment line from `bundle-env` * added option switch `-u` to skip prompts for autoupdate/install
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Larusso Thanks for the PR. Just reviewed the changes and I don't see changes with regards to ssl. Was that dropped? Pinging @joshdholtz |
|
@snatchev I removed this line from In this PR I still kep the brew open-ssl download logic. Because I don't know the exact reason why this is supposed to be better than letting ruby-build installing open-ssl. |
joshdholtz
approved these changes
Dec 4, 2019
joshdholtz
merged commit 5772885
into
fastlane:2.0-build-and-install-ruby-on-brew-install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I made some adjustments to your changes for the new installer
package.
fastlane_shimfilebundle-env-uto skip prompts for autoupdate/installfastlane_shimsymlink-able