object & secret store config naming changes for consistency #206
Conversation
|
Going to work on this again, try to maintain compatibility and move secret store over as well. |
`object_store` becomes `object_stores` for consistency with `backends`
and `dictionaries`. `path` becomes `file` for consistency with
dictionaries and geolocation config.
An example object store in the fastly.toml file might now look something
like:
```
[local_server]
object_stores.store_one = [{key = "one", file = "/path/to/something"}]
```
or
```
[local_server]
[local_server.object_stores]
store_one = [{key = "one", file = "/path/to/something"}]
```
or
```
[local_server]
[local_server.object_stores]
[[local_server.object_stores.store_one]]
key = "one"
file = "/path/to/something"
```
object_store is an alias for object_stores path is an alias for file
This makes it consistent with object store and other sections
joeshaw
force-pushed
the
joeshaw/object-store-naming
branch
from
458c8c2
to
9f0d8fc
Compare
joeshaw
changed the title
`object_store` becomes `object_stores` `secret_store` becomes `secret_stores` `path` becomes `file` This makes these more consistent with other parts of the manifest like dictionaries, backends, geolocation, etc. Companion to fastly/Viceroy#206
`object_store` becomes `object_stores` `secret_store` becomes `secret_stores` `path` becomes `file` This makes these more consistent with other parts of the manifest like dictionaries, backends, geolocation, etc. Companion to fastly/Viceroy#206
|
I noticed on https://developer.fastly.com/reference/compute/fastly-toml/#local-server it still says Is this just a case of the documentation has been neglected or did something change since this PR (and the CLI PR) were merged? I just went to the documentation to see how to setup a local object_store and noticed the code in the CLI would fail to parse UPDATE: Just familiarising myself with the CLI code and I'm not sure it matters as far as the CLI is concerned because the |
We didn't get around to the changes for the developer portal -- |
object_storebecomesobject_storesfor consistency withbackendsand
dictionaries.pathbecomesfilefor consistency withdictionaries and geolocation config.
An example object store in the fastly.toml file might now look something
like:
or
or
Backwards compatibility is maintained.
The Secret Store is updated to match the new Object Store conventions, but backwards compatibility is not maintained (because it's brand new and doesn't need to be).