Change default port from 7878 to 7676, which is what the Fastly CLI defaults to #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efaults to resolves #47
Integralist
reviewed
Jul 13, 2023
| @@ -49,7 +49,7 @@ built by `fastly compute build`. The Fastly CLI should put the blob at | |||
| viceroy bin/main.wasm | |||
| ``` | |||
|
|
|||
| This will start a local server (by default at: `http://127.0.0.1:7878`), which can | |||
| This will start a local server (by default at: `http://127.0.0.1:7676`), which can | |||
There was a problem hiding this comment.
Just to confirm that yes the CLI uses port 7676 by default:
https://github.com/fastly/cli/blob/main/pkg/commands/compute/serve.go#L78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this would be viewed as a breaking change as we are changing the default behaviour of the CLI.
If that is the case, then this involves bumping from 0.6.0 to 0.7.0 when it comes to releasing this
Resolves #47