Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have kv-store#open return an optional handle #372

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

elliottt
Copy link
Contributor

Modify the definition of the open function in the kv-store interface to return an optional handle instead of wrapping that case into the error.

Copy link

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are various functions where the optional-none error is used. Perhaps this error code can be entirely deprecated in the WIT.

@elliottt
Copy link
Contributor Author

There are various functions where the optional-none error is used. Perhaps this error code can be entirely deprecated in the WIT.

Yep, I'd like to deprecate that error value, but haven't audited all the calls yet to make sure they're all migrated.

Copy link
Contributor

@aturon aturon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, it's so exciting to start moving to higher-level types 🤩

@elliottt elliottt merged commit f23127e into main May 23, 2024
7 checks passed
@elliottt elliottt deleted the trevor/kv-store-open branch May 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants