add condition commands #1008
Merged
add condition commands #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested changes
Sep 8, 2023
There was a problem hiding this comment.
Look good. Just two minor edits required to be made and then this will be good to go.
One other thing was that the associated API is a VCL Object and so I'm wondering if instead of fastly condition ... it should be nested under the vcl package like 'custom' and 'snippet' are so the command changes to fastly vcl condition (I think that might make it clearer what a condition is).
Thanks!
|
Hi @Integralist , I've made a new commit according to your review. |
Integralist
requested changes
Sep 11, 2023
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #841