fix(github): update wasm-tools path #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfleming
approved these changes
Feb 20, 2024
Integralist
commented
Feb 21, 2024
| @@ -15,8 +15,6 @@ RUN rustup toolchain install ${RUST_TOOLCHAIN} \ | |||
| && useradd -ms /bin/bash fastly | |||
|
|
|||
| USER fastly | |||
| # this forces the download of the crates index; it will save build time if the image was recently built | |||
| RUN cargo search --limit 0 | |||
There was a problem hiding this comment.
This change is unrelated to the PR itself but was needed as crates.io now returns a 500 Internal Server Error for this call (I'm able to replicate locally). I've pinged our Rust experts internally about whether something changed on the Crates end of things, but as it's a performance operation and doesn't directly affect functionality I decided the best thing to do is to just remove the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the latest release of wasm-tools https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.200.0 changed its release assets path.