Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tinygo version used in tests #1188

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Update tinygo version used in tests #1188

merged 1 commit into from
Apr 29, 2024

Conversation

jsocol
Copy link
Contributor

@jsocol jsocol commented Apr 26, 2024

Versions of tinygo before 0.31 do not have precompiled darwin-arm64
binaries. To continue using macos-latest runners, we need to update.

Versions of tinygo before 0.31 do not have precompiled darwin-arm64
binaries. To continue using macos-latest runners, we need to update.
@Integralist Integralist added the enhancement New feature or request label Apr 29, 2024
@Integralist
Copy link
Collaborator

Is this related to the CI error in #1187

@jsocol
Copy link
Contributor Author

jsocol commented Apr 29, 2024

Is this related to the CI error in #1187

Yep! I haven't been able to find exactly when, but at some point last week it seems like macos-latest Actions runners switched architectures.

I wanted to double check before merging, though, that there are no other reasons we've been using 0.27.0? Are there any potential issues or unknowns we should validate?

@Integralist
Copy link
Collaborator

Probably just the first tinygo version that we could use when developing the feature.

If I check the default CLI configuration...
https://github.com/fastly/cli/blob/main/.fastly/config.toml#L15-L16

We can see that we set a minimum tinygo version of 0.28.x 🤔

@Integralist
Copy link
Collaborator

And for clarification, in case you were unfamiliar with this file:
https://github.com/fastly/cli/blob/main/DEVELOPMENT.md#fastlyconfigtoml

@jsocol
Copy link
Contributor Author

jsocol commented Apr 29, 2024

Thanks! Just to double check my understanding, .fastly/config.toml ends up embedded in pkg/config.Static and the data ends up emitted for Go compute projects into the new project's fastly.toml, right? I wouldn't think we want to change the minimum tinygo version for WASI, but maybe it's OK to change the default for new fastly.toml? Should we do that in the same PR? Happy to add it, unless it deserves it's own write-up

@jsocol jsocol merged commit 65b3733 into main Apr 29, 2024
8 checks passed
@jsocol jsocol deleted the update-tinygo-for-ci branch April 29, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants