Add service search command #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamann
requested changes
Sep 23, 2020
There was a problem hiding this comment.
Thank you for your speedy contribution, @benzvan! Much appreciated.
Looks clean overall, just a couple of changes needed:
- We don't need to interact with the
manifestfor this command - You'll need to update the help output intergration test in
pkg/app/run_test.go - You need to fix some linting errors via
make fmt.
|
Thanks for the fast feedback. I'm working on your change requests and it looks like I'll have to dig in and understand the code a little more than copy/paste/rename :-D |
phamann
requested changes
Sep 24, 2020
Merged
|
No problem. I'll start looking at the next issue i created today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to call the
service/search?name=endpoint to return service descriptions without the service ID.Issue #151