Update the default Rust template to fastly-0.5.0 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Changes Made
This updates the branch used to clone the default Rust template to
a branch that includes the `fastly-0.5.0` crate.
That branch, which can be found here [1], includes most importantly
our PR's #19, and #20. (Linked below, [2] and [3] in the footnotes.)
### Changes NOT Made
The previous commit which updated the default version to `0.4.0`,
e505d08, included changes to our
`pkg/compute/testdata/build/Cargo.toml` file. This was already
changed in d25ef1a, and has been left out of this commit.
### Footnotes
[1]: https://github.com/fastly/fastly-template-rust-default/tree/0.5.0
[2]: fastly/compute-starter-kit-rust-default#19
[3]: fastly/compute-starter-kit-rust-default#20
|
This might fail because of a stale |
phamann
changed the title
phamann
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
馃憤 LGTM
Even though it didn't cause any tests to fail, I updated the Cargo.lock for consistency. I also changed the PR title as they're used in the automated CHANGELOG.md generation - in case you wondered why.
I wasn't quite sure how to update that without a working Go installation 馃槄
One day we'll get you to install Go 馃槀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 update the default rust template to fastly-0.5.0
Changes Made
This updates the branch used to clone the default Rust template to
a branch that includes the
fastly-0.5.0crate.That branch, which can be found
here1
includes most importantly our PR's fastly-template-rust-default/pull/19, and
fastly-template-rust-default/pull/20.
Changes NOT Made
The previous commit which updated the default version to
0.4.0,e505d08, included changes to our
pkg/compute/testdata/build/Cargo.tomlfile. This was alreadychanged in d25ef1a, and has been left out of this commit.