Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on empty directory #247

Merged
merged 6 commits into from Apr 13, 2021
Merged

Warn on empty directory #247

merged 6 commits into from Apr 13, 2021

Conversation

Integralist
Copy link
Collaborator

Problem: Not cleaning up hidden .cargo files has proven to cause issues for users who re-use directories.

@Integralist Integralist changed the title Integralist/20210412 init emptydir Warn on empty directory Apr 12, 2021
@Integralist Integralist added the enhancement New feature or request label Apr 12, 2021
cratelyn
cratelyn reviewed Apr 12, 2021
View reviewed changes
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this extra guardrail! I have a suggestion for the prompt, but that's a lightly-held position. This looks great to me ✨

pkg/compute/init.go Outdated Show resolved Hide resolved
@Integralist Integralist force-pushed the integralist/20210412_init_emptydir branch from e9c32ba to 8fb95a6 Compare April 12, 2021 15:33
@Integralist Integralist force-pushed the integralist/20210412_init_emptydir branch from d5762f0 to 74f1535 Compare April 13, 2021 10:48
@Integralist Integralist merged commit e785f23 into master Apr 13, 2021
@Integralist Integralist deleted the integralist/20210412_init_emptydir branch April 13, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cratelyn cratelyn cratelyn left review comments

@triblondon triblondon triblondon approved these changes

@phamann phamann Awaiting requested review from phamann

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Integralist @triblondon @cratelyn