fix bug in publish command caused by lack of flag override
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
a team and
triblondon
and removed request for
a team
triblondon
approved these changes
Jun 3, 2021
|
Is there a chance this regressed? I'm using Fastly CLI version $ fastly version
Fastly CLI version 0.31.0 (e2b6042)
Built with go version go1.16.5 linux/amd64
$ fastly compute publish --service-id=MY_SERVICE_ID
✓ Initializing...
✓ Verifying package manifest...
✓ Verifying local rust toolchain...
✓ Building package using rust toolchain...
✓ Creating package archive...
SUCCESS: Built rust package compute-edge-service (pkg/compute-edge-service.tar.gz)
ERROR: the Fastly API returned 404 Not Found: Record not found (Cannot find service 'SERVICE_ID_I_WANT_TO_OVERRIDE'). |
|
@gaastonsr Apologies, yes this looks to be a regression caused by #302 which accidentally undid these changes. I'll get a PR worked on to resolve this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: A report came in to say that using
publishwith the--service-idflag was causing an error stating the relevant service could not be found, while switching to thedeploycommand (which publish proxies to) the flag would work as expected.This was caused by the
publishcommand not overriding the manifest field used by thedeploycommand it was proxying to.