implement remediation error for dynamic config 'context deadline' #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
a team and
doramatadora
and removed request for
a team
doramatadora
approved these changes
Jun 4, 2021
fgsch
reviewed
Jun 4, 2021
Integralist
force-pushed
the
integralist/context-deadline-remediation
branch
from
d6139e7
to
ad4571c
Compare
Integralist
force-pushed
the
integralist/context-deadline-remediation
branch
2 times, most recently
from
9a6f1dd
to
2f0a3b6
Compare
Integralist
force-pushed
the
integralist/context-deadline-remediation
branch
from
2f0a3b6
to
5d9e524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Requests for the remote/dynamic configuration used by the CLI has a timeout configured. When this error is triggered it is returned directly to the user.
Solution: Wrap the error in a remediation to help guide users on the possible next steps to take.
Notes: I've moved a couple of constant variables into their own package to avoid a "import cycle" error.