Simplify logic for prefixing fastly spec to file #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users weren't seeing the
fastly.toml
spec URL in their configuration file (the logic was working for the majority of users who tested the code, but there appears to be an intermittent issue which would cause the spec URL insertion to fail).An internal recommendation was made to simplify the logic (described below), and that's what has been done in this PR (which we expect to also resolve the issue reported internally with the spec URL being omitted).
The original flow was to encode data to disk and then seek the start of the file, checking if the spec URL was absent, and if so prepend it to the file. This complex flow was done because previously the toml dependency would truncate the entire file and remove the fastly spec URL, but since changing to a new (maintained) toml dependency that truncation no longer happens when encoding data to disk.
This means the flow for writing the config back to disk is now simply:
fastly.toml
.